Remove usage of NoNansFPMath after LLVM 22#9039
Merged
alexreinking merged 1 commit intohalide:automated/upgrade-halide-llvmfrom Mar 16, 2026
Merged
Remove usage of NoNansFPMath after LLVM 22#9039alexreinking merged 1 commit intohalide:automated/upgrade-halide-llvmfrom
alexreinking merged 1 commit intohalide:automated/upgrade-halide-llvmfrom
Conversation
This was removed upstream and was a no-op when it got removed, so we can simply hide these options behind an if-def.
Contributor
Author
|
This is an alternative to #9029. That PR is incorrect as the string attribute got removed as well (although I don't think adding one will hurt). The attribute was a no-op when it got removed, so it doesn't make sense to do anything beyond just omit adding it in LLVM 23+. llvm/llvm-project#186285 was the PR that removed support. |
Contributor
Author
|
(This is the fix we used for our internal version of Halide when we bumped our internal LLVM version on Friday). |
Member
|
Thanks, this makes more sense than #9029 |
This was referenced Mar 15, 2026
Merged
alexreinking
changed the base branch from
main
to
automated/upgrade-halide-llvm
alexreinking
force-pushed
the
automated/upgrade-halide-llvm
branch
from
a7e0dbd to
6235b4b
Compare
alexreinking
changed the title
alexreinking
approved these changes
Mar 16, 2026
Member
|
Thanks @boomanaiden154 -- I'm merging this into the automated upgrade PR. |
alexreinking
merged commit 0bc833a
into
halide:automated/upgrade-halide-llvm
16 of 18 checks passed
alexreinking
pushed a commit
that referenced
this pull request
Mar 16, 2026
* Upgrade halide-llvm to 23.0.0.dev85505+g69780be1 * Remove usage of NoNansFPMath after LLVM 22 (#9039) This was removed upstream and was a no-op when it got removed, so we can simply hide these options behind an if-def. --------- Co-authored-by: halide-ci[bot] <266445882+halide-ci[bot]@users.noreply.github.com> Co-authored-by: Aiden Grossman <aidengrossman@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed upstream and was a no-op when it got removed, so we can simply hide these options behind an if-def.